[FFmpeg-devel] [PATCH] avcodec/xvmc: apply attribute_deprecated correctly

[Ganesh Ajjanagadde]

On Fri, Oct 9, 2015 at 7:34 PM, Ivan Kalvachev <ikalvachev at gmail.com> wrote:
> On 10/10/15, Ganesh Ajjanagadde <gajjanagadde at gmail.com> wrote:
>> This fixes a warning observed on Clang 3.7:
>> "warning: attribute 'deprecated' is ignored, place it after "struct" to
>> apply attribute to type declaration [-Wignored-attributes]"
>> and thus enables deprecation warning for the relevant struct.
>>
>> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
>> ---
>>  libavcodec/xvmc.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavcodec/xvmc.h b/libavcodec/xvmc.h
>> index c2e187c..465ee78 100644
>> --- a/libavcodec/xvmc.h
>> +++ b/libavcodec/xvmc.h
>> @@ -43,7 +43,7 @@
>>  #define AV_XVMC_ID                    0x1DC711C0  /**< special value to
>> ensure that regular pixel routines haven't corrupted the struct
>>                                                         the number is 1337
>> speak for the letters IDCT MCo (motion compensation) */
>>
>> -attribute_deprecated struct xvmc_pix_fmt {
>> +struct attribute_deprecated xvmc_pix_fmt {
>>      /** The field contains the special constant value AV_XVMC_ID.
>>          It is used as a test that the application correctly uses the API,
>>          and that there is no corruption caused by pixel routines.
>
> That struct should not be deprecated at all in FFmpeg.
>
> Should I send a patch?

Why then was there an attribute_deprecated? Was this a merge from
Libav? I myself have no opinions at all (and am not even qualified to
comment on it).

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel