[FFmpeg-devel] [PATCH] RFC: Automatic bitstream filtering

Michael Niedermayer michael at niedermayer.cc
Wed Oct 7 14:08:48 CEST 2015

On Tue, Oct 06, 2015 at 08:07:08PM -0500, Rodger Combs wrote:
> This solves the problem discussed in https://ffmpeg.org/pipermail/ffmpeg-devel/2015-September/179238.html
> by allowing AVCodec::write_header to be delayed until after packets have been
> run through required bitstream filters in order to generate global extradata.
> It also provides a mechanism by which a muxer can add a bitstream filter to a
> stream automatically, rather than prompting the user to do so.
> I'd like to split this into 4 commits:
> - Moving av_apply_bitstream_filters from ffmpeg.c to its own API function
> - Other lavf API changes
> - Use of the new API in matroskaenc
> - The minor style tweak in matroskaenc
> There are a few other changes I think should be made before this is applied:
> - Adding BSF arguments to AVBitStreamFilterContext rather than passing them
> manually on each packet
> - Providing an API to add a bitstream filter to an AVStream, rather than doing
> so manually, and using it in check_bitstream
> - Using said API in ffmpeg_opt.c and removing ffmpeg.c's own BSF handling
> - Adding check_bitstream to other muxers that currently prompt the user to add
> bitstream filters (such as aac_adtstoasc and h264_mpeg4toannexb). It could also
> be used by e.g. movenc for generating the EAC3-specific atom.
> ---
>  ffmpeg.c                  | 45 ++++--------------------------------------
>  libavformat/avformat.h    | 16 +++++++++++++++
>  libavformat/matroskaenc.c | 22 ++++++++++++++++++++-
>  libavformat/mux.c         | 25 +++++++++++++++++++++++-
>  libavformat/utils.c       | 50 +++++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 115 insertions(+), 43 deletions(-)

i know its just a RFC but as i tested it ... it fails fate
make: *** [fate-binsub-mksenc] Error 1
make: *** [fate-acodec-tta] Error 1
make: *** [fate-seek-lavf-mkv] Error 1

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151007/8e6a37e9/attachment.sig>

More information about the ffmpeg-devel mailing list