[FFmpeg-devel] [PATCH 1/2] avfilter/all: propagate errors of functions from avfilter/formats

Nicolas George george at nsup.org
Tue Oct 6 15:25:05 CEST 2015

Le quintidi 15 vendémiaire, an CCXXIV, Ronald S. Bultje a écrit :
> >      // inlink supports any channel layout
> >      layouts = ff_all_channel_counts();
> > -    ff_channel_layouts_ref(layouts, &inlink->out_channel_layouts);
> > +    if (!layouts)
> > +        return AVERROR(ENOMEM);
> > +    if ((ret = ff_channel_layouts_ref(layouts,
> &inlink->out_channel_layouts)) < 0) {
> > +        ff_channel_layouts_unref(&layouts);
> > +        return ret;
> > +    }

> I already feel fully inadequate to review this patch :-D. But this looks
> weird.

What do you find weird in this change?

(What I find weird is that your MUA exhibits the same bogus quoted lines
re-wrapping behaviour than outlook more than ten years ago.)

>	 My proposal is that someone familiar with avfilter review this.
> Nicolas, Clement, Stefano, Michael, Paul, (I probably forgot some people,)
> can one of you volunteer?

I have looked at the changes for the files I know. I will progressively look
at the rest of the changes and post here if I find something not right, but
I can not guarantee I will not miss something. Several pairs of eyes are
always better.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151006/915127b2/attachment.sig>

More information about the ffmpeg-devel mailing list