[FFmpeg-devel] [PATCH 1/3] lavfi/af_pan: check ff_all_channel_counts() return.

Nicolas George george at nsup.org
Tue Oct 6 15:04:04 CEST 2015

Le quintidi 15 vendémiaire, an CCXXIV, Ganesh Ajjanagadde a écrit :
> The 1000 line diff I posted should take care of this and all other
> such unchecked stuff in query_formats across libavfilter :). I don't
> mind either way, though if this is applied, I will perhaps need to
> rebase my stuff to avoid merge conflicts. Really it is a question of
> whether people want a single patch or multiple patches - note that
> there are over 40 files that need cleanup.

I had your patch in my inbox to review the parts that I maintain, along with
the new Coverity report. I just looked at it: it is more complete than these
three patches, and I would not cause you extra work with conflicts, so from
my point of view, please go ahead.

It would probably be better if the commit message contains the CID numbers:
at least 1325679 and 1325680, but that is rather minor.

Thanks for your efforts.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151006/359a984c/attachment.sig>

More information about the ffmpeg-devel mailing list