[FFmpeg-devel] [PATCH] avfilter/buffersrc: add av_warn_unused_result attributes

Nicolas George george at nsup.org
Tue Oct 6 10:01:40 CEST 2015

Le quartidi 14 vendémiaire, an CCXXIV, Ganesh Ajjanagadde a écrit :
> This adds av_warn_unused_result whenever it is relevant.
> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
> ---
>  libavfilter/buffersrc.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

I do not have much of an opinion about this. It looks right in principle,
but warnings sometimes have unexpected advert effects.

> -int av_buffersrc_add_frame_flags(AVFilterContext *buffer_src,
> +av_warn_unused_result int av_buffersrc_add_frame_flags(AVFilterContext *buffer_src,
>                                   AVFrame *frame, int flags);

It is a bit sad to break alignment, though. I would slightly prefer having
the long attribute on a line by itself:

int av_yada_yada_yada(argu *ments);

... if people are ok with it too. Otherwise, reindenting with the same
commit seems acceptable in this case.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151006/522aba1d/attachment.sig>

More information about the ffmpeg-devel mailing list