[FFmpeg-devel] [PATCH 1/2] avcodec/alacdec: split off decorrelate_stereo and append_extra_bits as alacdsp

James Almer jamrial at gmail.com
Sun Oct 4 18:34:52 CEST 2015

On 10/4/2015 7:35 AM, Michael Niedermayer wrote:
> On Sun, Oct 04, 2015 at 01:31:27AM -0300, James Almer wrote:
>>> +        if (decorr_left_weight) {
>> So while i was writing a checkasm unit i started looking at the possible
>> values for this, and found out that apparently it's either 0 or 1.
>> Since the function below is not called when it's 0, wouldn't that mean
>> it's a pointless argument?
>> I'll have to redo the asm function if that's the case, and change the
>> prototype and boilerplate c version.
> why would it only be 0 or 1 ?
> (it sure could be in actual files but the syntax allows 8bit values)

Our encoder at least does as much (see alac_stereo_decorrelation() in
alacenc.c). Haven't tried others, so unless someone that knows the spec
chimes in I'll leave it as is.

More information about the ffmpeg-devel mailing list