[FFmpeg-devel] [PATCH] avcodec: remove old vdpau decoder implementation

[wm4]

On Sat, 3 Oct 2015 22:23:21 +0200
Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> On Saturday 03 October 2015 10:05:29 pm wm4 wrote:
> > Ping. Will push in 24 hours or so if nobody complains.
> 
> The reason I am against this is just that users told me 
> repeatedly (in person) that they switched from the dark 
> side to FFmpeg because this (and possibly) other API 
> was removed there.

As I've said several times, progress is not possible (or requires lots
of wasted energy) if we don't drop obsolete APIs. And at this point,
the new vdpau API is definitely superior over the old one. I don't know
why anyone would want to use the old API.

> I simply don't understand what the advantage is of 
> removing a few lines of code.

That's not a few lines, that's over 600 lines. To make it worse, it's
all duplicated code, duplicating functionality the vdpau hwaccel
provides. Unlike the hwaccel code, it's not cleanly integrated either.
Just look how intrusive it is, while hwaccel is basically just a bunch
of callbacks in the right places (and works for multiple hwdec APIs, not
just vdpau).