[FFmpeg-devel] [PATCH] Map description to the (c)inf tag

[Michael Niedermayer]

On Sun, Nov 22, 2015 at 11:51:15PM -0500, Brian Wheeler wrote:
> Signed-off-by: Brian Wheeler <bdwheele at indiana.edu>
> ---
>  libavformat/mov.c    | 2 +-
>  libavformat/movenc.c | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 0eb7272..960667f 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -342,7 +342,7 @@ static int mov_read_udta_string(MOVContext *c, AVIOContext *pb, MOVAtom atom)
>      case MKTAG(0xa9,'g','e','n'): key = "genre";     break;
>      case MKTAG(0xa9,'g','r','p'): key = "grouping";  break;
>      case MKTAG(0xa9,'h','s','t'): key = "host_computer"; break;
> -    case MKTAG(0xa9,'i','n','f'): key = "comment";   break;
> +    case MKTAG(0xa9,'i','n','f'): key = "description"; break;
>      case MKTAG(0xa9,'l','y','r'): key = "lyrics";    break;
>      case MKTAG(0xa9,'m','a','k'): key = "make";      break;
>      case MKTAG(0xa9,'m','o','d'): key = "model";     break;
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 53e3772..ad29cb6 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -3073,6 +3073,7 @@ static int mov_write_udta_tag(AVIOContext *pb, MOVMuxContext *mov,
>          mov_write_string_metadata(s, pb_buf, "\251aut", "author",      0);
>          mov_write_string_metadata(s, pb_buf, "\251alb", "album",       0);
>          mov_write_string_metadata(s, pb_buf, "\251day", "date",        0);
> +        mov_write_string_metadata(s, pb_buf, "\251inf", "description", 0);
>          mov_write_string_metadata(s, pb_buf, "\251swr", "encoder",     0);
>          // currently ignored by mov.c
>          mov_write_string_metadata(s, pb_buf, "\251des", "comment",     0);

i tried this with some files and the one from
https://trac.ffmpeg.org/ticket/3594
changed in output
description     : Created for use on squarenet.org only.
vs.
comment         : Created for use on squarenet.org only.

iam not a native english speaker but isnt "comment" more fitting?

do you have a sample where this patch improves the information
output ?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151124/39e19b5f/attachment.sig>