[FFmpeg-devel] [PATCH] avformat/rtpdec_mpa_robust: change assignment to equality test in conditional

[Ganesh Ajjanagadde]

On Wed, Oct 28, 2015 at 10:19 PM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
> On Tue, Oct 27, 2015 at 07:58:03PM -0400, Ganesh Ajjanagadde wrote:
>> In the spirit of commit 8199908fdf9b3797cceaea9d1e2fc09d02ef7309, likely
>> typo originally.
>>
>> Found by enabling -Wparentheses on clang 3.7 and running a manual audit.
>> To the best of my knowledge, no such instances remain.
>>
>> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
>> ---
>>  libavformat/rtpdec_mpa_robust.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavformat/rtpdec_mpa_robust.c b/libavformat/rtpdec_mpa_robust.c
>> index 6442a42..91ee98a 100644
>> --- a/libavformat/rtpdec_mpa_robust.c
>> +++ b/libavformat/rtpdec_mpa_robust.c
>> @@ -166,7 +166,7 @@ static int mpa_robust_parse_packet(AVFormatContext *ctx, PayloadContext *data,
>>              "Received packet without a start fragment; dropping.\n");
>>          return AVERROR(EAGAIN);
>>      }
>> -    if (adu_size = data->adu_size ||
>> +    if (adu_size == data->adu_size ||
>
> i suspect that this should be !=
>
> Gilles, can you confirm ?

Been over 2 weaks, is it ok to push with the !=?

>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> It is what and why we do it that matters, not just one of them.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>