[FFmpeg-devel] [PATCH] avformat/mxfenc: Only store user comment related tags when needed

[tim nicholson]

On 09/11/15 17:56, Michael Niedermayer wrote:
> From: Michael Niedermayer <michael at niedermayer.cc>
> 
> Also support disabling them as they seem to cause problems to some
> Users.
> 
> [..]
> -    for (i = 0; i < local_tag_number; i++) {
> +    for (i = 0; i < FF_ARRAY_ELEMS(mxf_local_tag_batch); i++) {
>          avio_wb16(pb, mxf_local_tag_batch[i].local_tag);
>          avio_write(pb, mxf_local_tag_batch[i].uid, 16);
>      }
> +    if (mxf->store_user_comments)
> +        for (i = 0; i < FF_ARRAY_ELEMS(mxf_local_tag_batch); i++) {

Is this right? I expected:-

for (i = 0; i < FF_ARRAY_ELEMS(mxf_user_comments_local_tag); i++) {


> +            avio_wb16(pb, mxf_user_comments_local_tag[i].local_tag);
> +            avio_write(pb, mxf_user_comments_local_tag[i].uid, 16);
> +        }
>  }



-- 
Tim.
Key Fingerprint 38CF DB09 3ED0 F607 8B67 6CED 0C0B FC44 8B0B FC83