[FFmpeg-devel] [PATCH] avformat/mxfenc: Support storing signal standard

[Michael Niedermayer]

On Tue, May 26, 2015 at 02:43:15PM +0200, Michael Niedermayer wrote:
> On Tue, May 26, 2015 at 09:45:28AM +0100, tim nicholson wrote:
> > On 24/05/15 02:15, Michael Niedermayer wrote:
> > > also store 1 for D10
> > > 
> > > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > > ---
> > >  libavformat/mxfenc.c            |   11 +++++++++++
> > >  tests/ref/lavf/mxf              |    6 +++---
> > >  tests/ref/lavf/mxf_d10          |    2 +-
> > >  tests/ref/lavf/mxf_opatom       |    2 +-
> > >  tests/ref/lavf/mxf_opatom_audio |    2 +-
> > >  5 files changed, 17 insertions(+), 6 deletions(-)
> > > 
> > 
> > Do we want to make this an edge case for D10 muxing only, or should we
> > be aiming for it to be more universal?
> 
> i dont see how it can be made more universal in a way that has
> acceptable reliability
> 
> 
> > 
> > Personally I try to avoid edge cases but I can see that trying to be
> > more universal could be difficult for a number of reasons in this case.
> > 
> > If we keep this as an edge case perhaps the commit message should say so:-
> > 
> 
> >  "Support storing signal standard for D10 muxing"
> 
> ill add that
> 
> thanks

applied

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150528/42242d1e/attachment.asc>