[FFmpeg-devel] [PATCH 2/2] x86inc: Clear __SECT__

[Michael Niedermayer]

On Mon, May 25, 2015 at 04:02:33PM -0700, Timothy Gu wrote:
> This commit silences warning(s) like:
> 
>     libavcodec/x86/fft.asm:93: warning: section flags ignored on section
>     redeclaration
> 
> The cause of this warning is that because `struc` and `endstruc` attempts to
> revert to the previous section state [1]. The section state is stored in the
> macro __SECT__, defined by x86inc.asm to be `.note.GNU-stack ...`, through the
> `SECTION` directive [2].  Thus, the `.note.GNU-stack` section is defined twice
> (once in x86inc.asm, once during `endstruc`), causing the warning.
> 
> That is the first part of the commit: using the primitive `[section]` format
> for .note.GNU-stack etc., which does not update `__SECT__` [2].
> 
> That fixes only half of the problem. Even without any `SECTION` directives,
> `__SECT__` is predefined as `.text`, which conflicting with the later
> `SECTION_TEXT` (which expands to `.text align=16`).
> 
> [1]: http://www.nasm.us/doc/nasmdoc6.html#section-6.4
> [2]: http://www.nasm.us/doc/nasmdoc6.html#section-6.3
> ---
> 
> Better patch as suggested by Ronald.
> 
> ---
>  libavutil/x86/x86inc.asm | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150528/23bfbdcb/attachment.asc>