[FFmpeg-devel] [PATCH] libshine: fix support for shine 3.0

Michael Niedermayer michaelni at gmx.at
Sun May 24 18:56:50 CEST 2015

On Sun, May 24, 2015 at 03:52:21PM +0200, Andreas Cadhalpun wrote:
> shine_encode_buffer expects written to be an int pointer, while the
> previous shine_encode_frame expected it to be a long pointer.
> Thus encoding with libshine currently always fails with
> "internal buffer too small", because a negative return value of
> shine_encode_buffer is interpreted as a very large long value.
> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> ---
>  libavcodec/libshine.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

LGTM, assuming that the type matches all libshine versions our
code can be built with


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150524/4c1631ae/attachment.asc>

More information about the ffmpeg-devel mailing list