[FFmpeg-devel] [PATCH 2/4] mov: check for positive sample->size

[Andreas Cadhalpun]

On 24.05.2015 00:46, Michael Niedermayer wrote:
> On Sun, May 24, 2015 at 12:04:23AM +0200, Andreas Cadhalpun wrote:

>> +    if (!sample->size) {
>> +        av_log(s, AV_LOG_ERROR, "sample size is zero\n");
>> +        return AVERROR_INVALIDDATA;
>> +    }
> 
> this would cause failure to demux future packets, i think its
> better to skip this but continue without failing

On 24.05.2015 09:21, Yusuke Nakamura wrote:
> 14496-12 does not prohibit sample_size = 0.
>
> See ISO/IEC 14496-12:2012 Corrected ver. 8.7.3.1 Definition.
>
> NOTE A sample size of zero is not prohibited in general, but it must be
> valid and defined for the coding
> system, as defined by the sample entry, that the sample belongs to.

OK, that was a bad idea.

Attached patch fixes the problem in a better way.

Best regards,
Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mov-check-for-negative-stsc-count.patch
Type: text/x-diff
Size: 1102 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150524/74cddc18/attachment.bin>