[FFmpeg-devel] [PATCH] Revert: mpegvideo: Drop err_recognition AND mpegvideo: Drop flags and flags2

[wm4]

On Sat, 23 May 2015 19:33:15 +0200
Michael Niedermayer <michaelni at gmx.at> wrote:

> On Sat, May 23, 2015 at 06:16:49PM +0200, wm4 wrote:
> > On Fri, 22 May 2015 23:59:54 +0200
> > Michael Niedermayer <michaelni at gmx.at> wrote:
> > 
> > > this increases mpeg4 and msmpeg4v3 decoding speed by about 0.3-0.5% overall
> > 
> > Nobody cares. If it makes the code slightly cleaner, it's good. The
> > code is terrible enough as it is.
> 
> Can you explain how the original commits make the code cleaner in
> your oppinon ?
> 
> [...]
> 

It removes 3 fields from MpegEncContext, all of them apparently
redundant. It's very minor, but at least it's something.

(Besides, I'd argue that if such a small indirection actually makes the
decoder slower, a much bigger speedup could be achieved by not checking
the flags at all, e.g. by ripping out features nobody actually uses.)