[FFmpeg-devel] [PATCH] avformat/mxfenc: Add color siting element

Michael Niedermayer michaelni at gmx.at
Fri May 22 14:30:07 CEST 2015


On Thu, May 21, 2015 at 03:06:11PM +0100, tim nicholson wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 21/05/15 11:59, Michael Niedermayer wrote:
> > On Thu, May 21, 2015 at 09:00:56AM +0200, Tomas Härdin wrote:
> >> [..]
> >> Why is this "guessing" code in mxfenc? This should be something that'
> s
> >> taken care of before calling any muxer (like in
> >> avformat_write_header()), so everyone can benefit from it and so ther
> e's
> >> less risk of duplication when it's needed elsewhere.
> >>
> >> I've seen stunts like this pulled in more places than mxfenc, where
> >> muxers will do dubious things like parse certain kinds of essence. I 
> am
> >> not a fan.
> > 
> > nor am i, ill try to move it into common code
> > 
> 
> +1 to both your comments its why I have hesitated on some of the other
> mxf metadata thats been requested.

change made
patch applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150522/ad5f748c/attachment.asc>


More information about the ffmpeg-devel mailing list