[FFmpeg-devel] [PATCH] avcodec/vp9: Use separate memset for counts.eob

Michael Niedermayer michaelni at gmx.at
Fri May 15 13:04:09 CEST 2015


On Fri, May 15, 2015 at 06:59:50AM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Fri, May 15, 2015 at 5:10 AM, Michael Niedermayer <michaelni at gmx.at>
> wrote:
> 
> > Makes no real difference, but maybe scares coverity less (CID1297578)
> >
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  libavcodec/vp9.c |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c
> > index db3f541..4655e9a 100644
> > --- a/libavcodec/vp9.c
> > +++ b/libavcodec/vp9.c
> > @@ -867,7 +867,8 @@ static int decode_frame_header(AVCodecContext *ctx,
> >      }
> >
> >      if (s->keyframe || s->intraonly) {
> > -        memset(s->counts.coef, 0, sizeof(s->counts.coef) +
> > sizeof(s->counts.eob));
> > +        memset(s->counts.coef, 0, sizeof(s->counts.coef));
> > +        memset(s->counts.eob,  0, sizeof(s->counts.eob));
> >      } else {
> >          memset(&s->counts, 0, sizeof(s->counts));
> >      }
> 
> 
> LGTM.

applied

thanks

[...]
--
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150515/62903fc4/attachment.asc>


More information about the ffmpeg-devel mailing list