[FFmpeg-devel] [PATCH] hevc: make avcodec_decode_video2() fail if get_format() fails

wm4 nfxjfg at googlemail.com
Thu May 14 18:27:31 CEST 2015

Personally, I need to the decoder to back out if get_format() returns no
useable pixel format. This didn't work because the error code was not
propagated down the call chain. This in turn happened because the
variable declaration removed in this patch shadowed the variable, whose
value is returned at the end of the function. Consequently, failures of
decode_nal_unit() were ignored in this place.
 libavcodec/hevc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c
index 459030c..199a3b9 100644
--- a/libavcodec/hevc.c
+++ b/libavcodec/hevc.c
@@ -3000,7 +3000,6 @@ static int decode_nal_units(HEVCContext *s, const uint8_t *buf, int length)
     /* parse the NAL units */
     for (i = 0; i < s->nb_nals; i++) {
-        int ret;
         s->skipped_bytes = s->skipped_bytes_nal[i];
         s->skipped_bytes_pos = s->skipped_bytes_pos_nal[i];

More information about the ffmpeg-devel mailing list