[FFmpeg-devel] [PATCH] fate: Test pullup and fieldmatch with 5 instead of 1 frame

[Clément Bœsch]

On Tue, May 12, 2015 at 12:29:10PM +0200, Michael Niedermayer wrote:
> On Tue, May 12, 2015 at 10:21:47AM +0200, Clément Bœsch wrote:
> > On Mon, May 11, 2015 at 12:59:57PM +0200, Michael Niedermayer wrote:
> > > On Mon, May 11, 2015 at 07:34:11AM +0200, Clément Bœsch wrote:
> > > > On Mon, May 11, 2015 at 12:44:14AM +0200, Michael Niedermayer wrote:
> > > > > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > > > > ---
> > > > >  tests/fate-run.sh                        |    3 ++-
> > > > >  tests/fate/filter-video.mak              |    4 ++--
> > > > >  tests/ref/fate/filter-pixfmts-fieldmatch |   10 +++++-----
> > > > >  tests/ref/fate/filter-pixfmts-pullup     |   24 ++++++++++++------------
> > > > >  4 files changed, 21 insertions(+), 20 deletions(-)
> > > > > 
> > > > 
> > > > Hum, 5 frames test with telecine... I'd really go for more.
> > > 
> > > ok, how many frames should we use ?
> > > 
> > 
> > Dunno, maybe 15 to 25.
> 
> applied with that change
> 
> 
> > 
> > BTW, I have the feeling that 5 frames is not really enough for testing a
> > some of the other filters as well. The first two things that come to my
> > mind are:
> > 
> > - the filters that rely on perms=random might not have enough coverage on
> >   the permissions
> > - the filters that use video samples might not come across
> >   interesting/appropriate frames (whether it's based on the content or the
> >   properties of frames such as P/B/I for pp filters)
> > 
> > Fortunately, pixfmts and video_filter command seems not used that much.
> 
> are there any more tests which need changes ?

Maybe these 3:

fate/filter-video.mak:fate-filter-edgedetect: CMD = video_filter "format=gray,perms=random,edgedetect"
fate/filter-video.mak:fate-filter-edgedetect-colormix: CMD = video_filter "format=gbrp,perms=random,edgedetect=mode=colormix"
fate/filter-video.mak:fate-filter-hue: CMD = video_filter "perms=random,hue=s=sin(2*PI*t)+1"

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150514/91fa09b0/attachment.asc>