[FFmpeg-devel] [PATCH] id3v2: catch avio_read errors in check_tag

Michael Niedermayer michaelni at gmx.at
Mon May 11 20:29:50 CEST 2015

On Mon, May 11, 2015 at 08:07:49PM +0200, Andreas Cadhalpun wrote:
> Since len is an unsigned int, the comparison is currently treated as
> unsigned and thus ignores all errors from avio_read.
> Thus cast len to int, which is unproblematic, because at that point len
> is between 0 and 4.
> This fixes 'Conditional jump or move depends on uninitialised value'
> valgrind warnings in is_tag.



Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150511/f5168fc1/attachment.asc>

More information about the ffmpeg-devel mailing list