[FFmpeg-devel] [PATCH]Tell users about -use_absolute_path

[wm4]

On Fri, 8 May 2015 12:37:48 +0000 (UTC)
Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> wm4 <nfxjfg <at> googlemail.com> writes:
> 
> > > +       "Absolute path %s not tried for security reasons, "
> > > +       "pass -use_absolute_path 1 to force using absolute paths\n",
> 
> > ffmpeg.c options/conventions have no place in the libraries.
> 
> How is this libavformat option related to ffmpeg.c?
> 
> Please suggest a wording that is also acceptable for 
> library users (they can't guess "use_absolute_path" 
> either I guess).

The problem is that this code was written with ffmpeg.c in mind, so you
assumed that it was fine to open new files inside of libavformat, and
you had to add an option to let ffmpeg.c "fix" the hardcoded policy if
needed.

The correct way is adding a callback for opening new files, and let the
API user decide. ffmpeg.c can then implement its own use_absolute_path
option.