[FFmpeg-devel] [PATCH 1/2] id3v2: do not export APIC description if empty

Michael Niedermayer michaelni at gmx.at
Fri May 8 01:18:35 CEST 2015

On Thu, May 07, 2015 at 11:56:36PM +0200, wm4 wrote:
> APIC tags always have a description. Tag writers obviously leave it
> empty if there is no description. In this case, libavformat would export
> "" as title. Do not set the title instead.
> ---
> Somewhat questionable. Take it or leave it.
> ---
>  libavformat/id3v2.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)



Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150508/f2741ee1/attachment.asc>

More information about the ffmpeg-devel mailing list