[FFmpeg-devel] [PATCH 1/4] FFV1 specification: Change formatting of pseudo-code

[Michael Niedermayer]

On Fri, May 01, 2015 at 02:25:37PM +0200, Jerome Martinez wrote:
> Le 01/05/2015 13:49, Michael Niedermayer a écrit :
> >On Fri, May 01, 2015 at 12:13:22PM +0200, Jerome Martinez wrote:
> >
> >>-if (keyframe) {
> >>+if ( keyframe ) {
> >[...]
> >>-if(version<2)
> >>+if( version < 2 )
> >that doesnt look consistent to me
> 
> Fixed (I missed this one and several other "if (" and "for (", all fixed).
> 
> 
> 
> >
> >-for(i=0; i<slice_count; i++)
> >+for( i = 0; i < slice_count; i++)
> >should there be a spae before )
> 
> Fixed.
> 
> >
> >are you sure your patch makes things more and not less consistent ?
> 
> 
> I apologized not to have caught all of them.
> 
> >
> >[...]
> >>@@ -8047,7 +8047,7 @@ QuantizationTablePerContext(i, j, scale)
> >>  \begin_inset space ~
> >>  \end_inset
> >>-scale*=2*len_count[i][j]-1
> >>+scale *= 2 * len_count[i][j] - 1
> >here you leave [] in other cases you replace [] by () for arrays
> >that mix is alot worse than just leaving C syntax
> 
> I don't understand: I let "[]" for data. "()" is used for function
> calls, for more coherency. I plan to define LyX Document LumaLine( y
> ) and all other line-related lines (which are function calls, they
> are not data in the bitstream) in future patches, as I did for
> QuantizationTable(). Do you prefer I let "[]" for now?
> BTW, I also changed to "[ i ]" formating as found in other specifications.
> 
> New patch attached.

>  ffv1.lyx |  149 +++++++++++++++++++++++++++++++--------------------------------
>  1 file changed, 75 insertions(+), 74 deletions(-)
> b1b31a155b61a157458dfaf6ffce571093909949  0001-Change-formatting-of-pseudo-code.patch
> From b9fc2a09c5875ed81adc4b81ed42475c2c30fdf8 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Martinez?= <jerome at mediaarea.net>
> Date: Fri, 1 May 2015 14:19:44 +0200
> Subject: [PATCH 1/4] Change formatting of pseudo-code.

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150502/d0587958/attachment.asc>