[FFmpeg-devel] [PATCH 1/4] libavdevice/avfoundation: add framerate and video size options

[Thilo Borgmann]

Am 27.03.15 um 14:34 schrieb Matthieu Bouron:
> On Sat, Mar 21, 2015 at 4:51 PM, Thilo Borgmann <thilo.borgmann at mail.de>
> wrote:
> [...]
>> +        [video_device setValue:selected_format forKey:@"activeFormat"];
>> +        [video_device setValue:min_frame_duration
>> forKey:@"activeVideoMinFrameDuration"];
>> +        [video_device setValue:min_frame_duration
>> forKey:@"activeVideoMaxFrameDuration"];
>>                                 ^^^
>> Should be max_frame_duration in the third line.
>> IIRC there is functionality in the API to check if setting
>> min/max_frame_duration is available for the device, isn't it? Please
>> check, in
>> case there it is not, there is an alternative way to set the framerate
>> (IIRC).
>>
> 
> It is purely intentionnal to use the min_frame_duration for the
> activeVideoMaxFrameDuration to acheive a better consistant framerate.
> There is no way to check if the range is accepted by the device but as
> stated by the documentation, applied range values that does not come from
> ranges returned by the API will throw an exception.
> There is an alternative way to set the framerate using
> AVCaptureConnection.setVideo(Min|Max)FrameDuration but it has been
> deprecated in iOS 7 and I do not intend to support it.

I misunderstood your these lines.

Patch ok, please apply.

Thanks,
Thilo