[FFmpeg-devel] [PATCH 4/4] lavf/libsmbclient: implement directory listing callbacks

[Lukasz Marek]

On 26.03.2015 01:25, Mariusz Szczepańczyk wrote:
> ---
>   libavformat/libsmbclient.c | 93 ++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 93 insertions(+)

[...]

> +    switch (dirent->smbc_type) {
> +    case SMBC_DIR:
> +        entry->type = AVIO_ENTRY_DIRECTORY;
> +        break;
> +    case SMBC_FILE:
> +        entry->type = AVIO_ENTRY_FILE;
> +        break;
> +    default:
> +        /* TODO: Find out what other types stand for and their correct
> +         * mappings. Probably some of them should be skipped. */
> +        entry->type = AVIO_ENTRY_UNKNOWN;
> +        break;
> +    }

Before it is merged it should handle:
SMBC_WORKGROUP, SMBC_SERVER, SMBC_FILE_SHARE

This implicates that AVIODirEntryType has to be extended and 
doc/examples/avio_list_dir.c from second patch as well,

It im not sure how to handle
SMBC_PRINTER_SHARE, SMBC_COMMS_SHARE, SMBC_IPC_SHARE
It can be set as unknown, it can be not listed at all, or also specific 
enums can be added. Printers are not relevant to ffmpeg at all.

Patch itself is ok, but it is not complete.