[FFmpeg-devel] [PATCH] lavf/avisynth: fix compilation, remove bundled headers

[Michael Niedermayer]

On Wed, Mar 25, 2015 at 01:59:18PM -0400, Stephen Hutchinson wrote:
> On Wed, Mar 25, 2015 at 12:49 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > ive applied patch 4 from the patchset too, does that fix it ?
> > if not please check the remaining 2 patches, i had not applied them
> > as they remove 2.5 support and i wanted to wait first to see if
> > someone posts a solution that keeps 2.5 support but if not ill apply
> > them too or if they are needed for build on non 2.5
> >
> 
> Even if manages to build, the changes from AVSC_INLINE to
> AVSC_API for those functions in the header will cause 2.5 to crash
> if someone tries using it.  Reimplemented versions of those
> functions would have to be added to the compat header (and as
> I mentioned on the mail for the 2.5 drop patch, it'd require
> navigating potential license potholes, and for 2.5 it just really isn't
> worth it).

applied the patches


> 
> The ideal solution per patch #4 would be to figure out why the exact
> same headers trip -Werror=implicit-function-declaration in FFmpeg
> while they don't in Libav.  Somehow I doubt it's only because of
> Libav's use of check_header in the --enable-avisynth configure check.

If i had to guess, i would say its because some compilers have an
exception for headers in some directories so that warnings in them
dont trigger build failures. IIUC this is needed due to the "high"
quality of some system headers, which otherwise would prevent the use
of some -Werror= options entirely

If thats correct then theres a problem in the headers in either case

[...]
--
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150325/5bb26e5d/attachment.asc>