[FFmpeg-devel] [PATCH] lavf/avisynth: fix compilation, remove bundled headers

[Michael Niedermayer]

On Wed, Mar 25, 2015 at 09:58:15AM -0600, Roger Pack wrote:
> On 3/25/15, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Tue, Mar 24, 2015 at 07:40:33PM +0100, Martin Herkt wrote:
> >> Merge commit 1530732 broke compilation with AviSynth enabled.
> >>
> >> There's really no reason to keep outdated, incompatible copies of
> >> these headers in the FFmpeg source tree. No one should be using
> >> AviSynth 2.5 either.
> >> ---
> >>  compat/avisynth/avisynth_c.h                       | 880
> >> ---------------------
> >>  compat/avisynth/avisynth_c_25.h                    |  68 --
> >>  compat/avisynth/avxsynth_c.h                       | 728
> >> -----------------
> >>  .../windowsPorts/basicDataTypeConversions.h        |  85 --
> >>  compat/avisynth/windowsPorts/windows2linux.h       |  77 --
> >>  doc/general.texi                                   |  23 +-
> >>  libavformat/avisynth.c                             |  27 +-
> >>  7 files changed, 35 insertions(+), 1853 deletions(-)
> >>  delete mode 100644 compat/avisynth/avisynth_c.h
> >>  delete mode 100644 compat/avisynth/avisynth_c_25.h
> >>  delete mode 100644 compat/avisynth/avxsynth_c.h
> >>  delete mode 100644
> >> compat/avisynth/windowsPorts/basicDataTypeConversions.h
> >>  delete mode 100644 compat/avisynth/windowsPorts/windows2linux.h
> >
> > Stephen Hutchinson has replaced the outdated headers while this was
> > stuck in the mailman que
> 
> Mine still doesn't build [at least cross compile, but I assume native]
> with the same errors reported in this thread...
> 
> CC	libavformat/avisynth.o
> In file included from libavformat/avisynth.c:33:0:
> ./compat/avisynth/avisynth_c.h: In function 'avs_is_same_colorspace':
> ./compat/avisynth/avisynth_c.h:363:17: error: implicit declaration of
> function 'avs_is_yv12' [-Werror=implicit-function-declaration]
>                  || (avs_is_yv12(x) && avs_is_yv12(y));

ive applied patch 4 from the patchset too, does that fix it ?
if not please check the remaining 2 patches, i had not applied them
as they remove 2.5 support and i wanted to wait first to see if
someone posts a solution that keeps 2.5 support but if not ill apply
them too or if they are needed for build on non 2.5

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

DNS cache poisoning attacks, popular search engine, Google internet authority
dont be evil, please
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150325/ac45a798/attachment.asc>