[FFmpeg-devel] Fix Patch for Ticket #2622- Remuxing of hdmv pgs subtitles

Philip Langdale philipl at overt.org
Tue Mar 24 04:14:22 CET 2015

Hi Niklesh,

On Mon, 23 Mar 2015 12:52:16 +0530
Niklesh Lalwani <lalwani1994 at gmail.com> wrote:

> Hi everyone,
> I have fixed the issue #2622 <https://trac.ffmpeg.org/ticket/2622>
> through this pull request <https://github.com/FFmpeg/FFmpeg/pull/125>.
> These changes enables to remux m2ts file so that the new file has
> playable subtitles.

This is a good change, but please re-send it to the mailing list using
git format-patch and git send-email - this is our preferred way of
reviewing changes.

> However, the subtitle stream type is still unknown, which is maybe
> due to missing description for HDMV_PGS_SUBTITLE under case
> AVMEDIA_TYPE_SUBTITLE in mpegtsenc.c. Can anyone explain what is
> going on with the descriptor handing?

To expand on this a little, mpegtsenc.c doesn't appear to be setting
the prog_reg_desc field - or at least not in any way I can understand,
and I'm dubious about whether mpegts.c is correctly reading
prog_reg_desc - the value for the first track appears to propagate to
all subsequent tracks, which makes it very hard to establish what's
going on.


More information about the ffmpeg-devel mailing list