[FFmpeg-devel] [PATCH 2/2] libavformat/mxfenc: add support for muxing mxf opatom audio

Tomas Härdin tomas.hardin at codemill.se
Mon Mar 23 21:05:02 CET 2015

On Sat, 2015-03-21 at 16:45 -0700, Mark Reid wrote:
> ---
>  libavformat/mxfenc.c | 100 ++++++++++++++++++++++++++++++++++++++++++---------
>  1 file changed, 83 insertions(+), 17 deletions(-)

Looks fine as far as I can tell. My only nitpick is that it might be
better to call "timecode rate" EditRate or "edit rate" instead, since
that is MXF parlance. Perhaps a bit bikeshed-y though. Does anyone else
have any preference?

An aside: would it ever make sense to use EditRate different from fps,
to force a certain rate? Something tells me there's a video filter or
something to do that already, so perhaps not an issue.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150323/3fdff327/attachment.asc>

More information about the ffmpeg-devel mailing list