[FFmpeg-devel] [FFmpeg-Devel] [GSoC] [PATCH 1/4] created x86 directory in libpostproc for standalone asm files

Michael Niedermayer michaelni at gmx.at
Mon Mar 23 01:01:33 CET 2015

On Sun, Mar 22, 2015 at 03:48:12PM -0400, Tucker DiNapoli wrote:
> From: Tucker DiNapoli <T.DiNapoli42 at gmail.com>
> This patch set contains implementations of various filters from libpostproc,
> translated from inline asm (in postprocess_template.c) into seperate yasm files.
> In addition support for sse2 and avx2 has been added via the use of the simd
> abstraction layer from x86inc.asm. There are 4 assembly files added, one is a 
> file of utility macros, one defines the layout of various structs used in libpostproc
> using the yasm struc directive, one implements several deinterlacing filters and 
> the last implements a deblocking filter. I am used to writing x86 asm for the
> gnu assembler so I'm still somewhat new at using yasm features, so any advice
> on how to better use yasm, better format my assembly, or any advice on my code
> in general would be appricated.

> I would like to submit these patches as my qualification task for the google
> summer of code. It may be hard to test the code as it can't be use with libpostproc 
> as is, this is because a significant part of the summer project is to modify
> the C code to support differing vector sizes. I think trying to change the
> library to interface with this new code is too much to ask for a qualification task,
> but if this code alone isn't enough I can work on something else if need be.

ive refactored postproc a bit so the loop now works in groups of
4 blocks this should make adding in SSE2 and AVX2 easier

also dont hesitate to cleanup the code further (in clean well split
patches though please)

and yes getting some working and testable code in is a requirement for
i dont think factorizing the code is really that hard but then well
i know the code so things look kind of easier to me

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150323/63b69e2b/attachment.asc>

More information about the ffmpeg-devel mailing list