[FFmpeg-devel] [PATCH] lavfi/eq: factorize code in process_command through a macro

[Michael Niedermayer]

On Sun, Mar 15, 2015 at 02:59:58PM +0100, Stefano Sabatini wrote:
> On date Friday 2015-03-13 20:05:35 +0100, Michael Niedermayer encoded:
> > On Fri, Mar 13, 2015 at 05:16:53PM +0100, Stefano Sabatini wrote:
> > > ---
> > >  libavfilter/vf_eq.c | 56 ++++++++++++++---------------------------------------
> > >  1 file changed, 15 insertions(+), 41 deletions(-)
> > 
> > i would be more in favor of a function than a macro but LGTM either
> > way, macros are harder to debug and all kind of line number based
> > outputs are basically useless with multiline macros, be that
> > static analyzers of dynamic ...
> > 
> > 
> > 
> > set_param(cmd, "gamma_g", &eq->gamma_g_pexp, args, ctx, eq, &ret);
> > set_param(cmd, "gamma_r", &eq->gamma_r_pexp, args, ctx, eq, &ret);
> > if (ret < 0)
> 
> Up.
> -- 
> FFmpeg = Fantastic Fundamental Miracolous Patchable Elitarian Gargoyle

>  vf_eq.c |   66 ++++++++++++++++++++++------------------------------------------
>  1 file changed, 23 insertions(+), 43 deletions(-)
> 3adede32119e8d758297b2a29a92b98cb17d1010  0001-lavfi-eq-factorize-code-in-process_command.patch
> From ee2157da84a30e043dfa55cf25a86ef751451bba Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefasab at gmail.com>
> Date: Fri, 13 Mar 2015 16:45:08 +0100
> Subject: [PATCH] lavfi/eq: factorize code in process_command()

LGTM

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150317/cfdcdaf1/attachment.asc>