[FFmpeg-devel] [PATCH v2] libavformat/mxfdec: export user comments metadata

[Michael Niedermayer]

On Sun, Mar 15, 2015 at 02:46:57PM -0700, Mark Reid wrote:
> On Sun, Mar 15, 2015 at 1:59 PM, James Almer <jamrial at gmail.com> wrote:
> 
> > On 13/03/15 10:58 PM, Mark Reid wrote:
> > > ---
> > >  libavformat/mxf.h    |  1 +
> > >  libavformat/mxfdec.c | 94
> > +++++++++++++++++++++++++++++++++++++++++++++++++---
> > >  2 files changed, 91 insertions(+), 4 deletions(-)
> >
> > From fate-mxf-missing-index-demux using valgrind
> >
> > ==6422==
> > ==6422== HEAP SUMMARY:
> > ==6422==     in use at exit: 128 bytes in 3 blocks
> > ==6422==   total heap usage: 481 allocs, 478 frees, 276,837 bytes allocated
> > ==6422==
> > ==6422== 48 bytes in 1 blocks are definitely lost in loss record 3 of 3
> > ==6422==    at 0x4C2C526: memalign (in
> > /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
> > ==6422==    by 0x4C2C641: posix_memalign (in
> > /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
> > ==6422==    by 0xD454CF: av_malloc (mem.c:95)
> > ==6422==    by 0xD454CF: av_mallocz (mem.c:252)
> > ==6422==    by 0xD454CF: av_calloc (mem.c:262)
> > ==6422==    by 0x5CA3B7: mxf_read_strong_ref_array (mxfdec.c:693)
> > ==6422==    by 0x5CA3B7: mxf_read_package (mxfdec.c:874)
> > ==6422==    by 0x5CD352: mxf_read_local_tags (mxfdec.c:2292)
> > ==6422==    by 0x5CD352: mxf_parse_klv (mxfdec.c:2340)
> > ==6422==    by 0x5CD352: mxf_read_header (mxfdec.c:2735)
> > ==6422==    by 0x639701: avformat_open_input (utils.c:466)
> > ==6422==    by 0x476B14: open_input_file (ffmpeg_opt.c:890)
> > ==6422==    by 0x477F77: open_files (ffmpeg_opt.c:2733)
> > ==6422==    by 0x477F77: ffmpeg_parse_options (ffmpeg_opt.c:2770)
> > ==6422==    by 0x468E46: main (ffmpeg.c:4010)
> > ==6422==
> > {
> >
> >
> Forgot to free MXFPackage->comment_refs, attached patch should fix memory
> leak

>  mxfdec.c |    1 +
>  1 file changed, 1 insertion(+)
> 202cb7a00fecba77e27403225c24add3b46dd2c0  0001-libavformat-mxfdec-fix-MXFPackage-comment_refs-memor.patch
> From d5b242850ddbec4e7ed2d9afdabf3169604b952e Mon Sep 17 00:00:00 2001
> From: Mark Reid <mindmark at gmail.com>
> Date: Sun, 15 Mar 2015 14:43:32 -0700
> Subject: [PATCH] libavformat/mxfdec: fix MXFPackage->comment_refs memory leak

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150316/ba8a4b41/attachment.asc>