[FFmpeg-devel] [RFC] libavfilter query_format() related functions error handling
u at pkh.me
Sat Mar 14 21:56:31 CET 2015
On Sat, Mar 14, 2015 at 03:25:19PM +0100, Michael Niedermayer wrote:
> On Sat, Mar 14, 2015 at 03:11:28PM +0100, Clément Bœsch wrote:
> > On Sat, Mar 14, 2015 at 01:33:12PM +0100, Nicolas George wrote:
> > > Le quartidi 24 ventôse, an CCXXIII, Michael Niedermayer a écrit :
> > > > ff_set_common_channel_layouts(ctx, ff_all_channel_layouts());
> > > > ff_set_common_formats(ctx, ff_make_format_list(sample_fmts));
> > > > ff_set_common_samplerates(ctx, ff_all_samplerates());
> > > >
> > What do you do about the 2nd argument being NULL by allocation error here?
> > Should the ctx passed there too?
> there are many possibilities like returning a specific pointer to a
> struct indicating errors but passing ret may be more intuitive
The more I look at this, the more I feel like I'm going to do the first
solution, which will allow an incremental patching, and will be more
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 473 bytes
Desc: not available
More information about the ffmpeg-devel