[FFmpeg-devel] [PATCH 1/5] lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

Michael Niedermayer michaelni at gmx.at
Sat Mar 14 18:38:26 CET 2015


On Sat, Mar 14, 2015 at 03:30:24PM +0000, Christophe Gisquet wrote:
> The later may yield incorrect code for on-stack variables.
> ---
>  libavcodec/dct-test.c           |  2 +-
>  libavcodec/h264_loopfilter.c    | 10 +++++-----
>  libavcodec/proresenc_anatoliy.c |  3 ++-
>  libavcodec/vp8.c                |  2 +-
>  4 files changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/libavcodec/dct-test.c b/libavcodec/dct-test.c
> index 30eca3e..f177dcc 100644
> --- a/libavcodec/dct-test.c
> +++ b/libavcodec/dct-test.c
> @@ -66,7 +66,7 @@ static const struct algo fdct_tab[] = {
>  };
>  
>  static void ff_prores_idct_wrap(int16_t *dst){
> -    DECLARE_ALIGNED(16, static int16_t, qmat)[64];
> +    LOCAL_ALIGNED(16, static int16_t, qmat, [64]);
>      int i;

this seems to break build

ffmpeg/libavcodec/dct-test.c: In function ‘ff_prores_idct_wrap’:
ffmpeg/libavcodec/dct-test.c:69:28: error: expected expression before ‘static’
ffmpeg/libavcodec/dct-test.c:69:13: warning: unused variable ‘la_qmat’

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150314/035ce813/attachment.asc>


More information about the ffmpeg-devel mailing list