[FFmpeg-devel] [PATCH 2/4] x86: xvid_idct: port MMX IDCT to yasm

[Ronald S. Bultje]

Hi,

On Fri, Mar 13, 2015 at 3:19 PM, Christophe Gisquet <
christophe.gisquet at gmail.com> wrote:

> Hi,
>
> 2015-03-13 14:34 GMT+01:00 Michael Niedermayer <michaelni at gmx.at>:
> >> They will not be used in any real world scenario.
> >
> > well it could be usefull in debuging in same cases
> > especially if all mmx code is disabled on x86_64, for any single
> > function its not too likely
>
> I believe fate and proper bug reports are here for that, even with
> your scenarios. I mean, for instance I can only test Win32/64, but
> neither linux x86, PPC nor ARM, so I haven't bought much improvement
> with this.
>
> So I'd, as well as several x86 implementers, prefer the MMX* code not
> to be built under ARCH_X86_32. You seemed to be fine with either.
>
> And this was accepted as an intermediate ground between not keeping
> all optimizations that only apply to 15+ yo systems (there are several
> people of that opinion), and keeping everything as is.


I think the "smaller binary" is sufficiently enough of a reason to disable
building that code on 64bit systems.

Ronald