[FFmpeg-devel] [PATCH] Reorganized libpostproc code

[Michael Niedermayer]

Hi

On Tue, Mar 10, 2015 at 11:57:56PM -0400, Tucker DiNapoli wrote:
> From: Tucker DiNapoli <T.DiNapoli42 at gmail.com>
> 
> The only changes were formating and moving code.
> ---
>  libpostproc/postprocess.c          |  436 ++----------
>  libpostproc/postprocess_c.c        | 1328 ++++++++++++++++++++++++++++++++++++
>  libpostproc/postprocess_internal.h |   30 +-
>  libpostproc/postprocess_template.c |  124 ++--
>  4 files changed, 1468 insertions(+), 450 deletions(-)
>  create mode 100644 libpostproc/postprocess_c.c

like james said, the changes need to be split, the code needs to
work after each patch and each patch should contain only related
changed
also submit patches early if possible, dont accumulate a huge patchset
before submission as someone might spot an issue in patch #1 and that
might cause potentially lots of rework in subsequent patches

also the code does not work after this patch:
make -k fate-filter-pp fate-filter-pp1 fate-filter-pp2 fate-filter-pp3 fate-filter-pp4 fate-filter-pp5 fate-filter-pp6

(you can also run make fate to run all tests not just the postprocess
tests)

[...]
--- ./tests/ref/fate/filter-pp5 2015-03-11 00:31:17.874675798 +0100
+++ tests/data/fate/filter-pp5  2015-03-11 11:27:01.911504671 +0100
@@ -1 +1 @@
-pp5                 5fc6703d42bd98942e5dd104ce220291
+pp5
\ No newline at end of file
Test filter-pp5 failed. Look at tests/data/fate/filter-pp5.err for details.
make: *** [fate-filter-pp5] Error 139
--- ./tests/ref/fate/filter-pp6 2015-03-11 00:31:17.874675798 +0100
+++ tests/data/fate/filter-pp6  2015-03-11 11:27:01.911504671 +0100
@@ -1 +1 @@
-pp6                 93b508d07bfcf4703aa7dff2d2ef5c03
+pp6
\ No newline at end of file
Test filter-pp6 failed. Look at tests/data/fate/filter-pp6.err for details.
make: *** [fate-filter-pp6] Error 139
--- ./tests/ref/fate/filter-pp2 2015-03-11 00:31:17.874675798 +0100
+++ tests/data/fate/filter-pp2  2015-03-11 11:27:01.911504671 +0100
@@ -1 +1 @@
-pp2                 975d4c1d489e42ddbd4a27464e8355af
+pp2
\ No newline at end of file
Test filter-pp2 failed. Look at tests/data/fate/filter-pp2.err for details.
make: *** [fate-filter-pp2] Error 139
--- ./tests/ref/fate/filter-pp  2015-03-11 00:31:17.874675798 +0100
+++ tests/data/fate/filter-pp   2015-03-11 11:27:01.911504671 +0100
@@ -1 +1 @@
-pp                  3730f1ed7bf244ce059d110e21f39bbd
+pp
\ No newline at end of file
--- ./tests/ref/fate/filter-pp4 2015-03-11 00:31:17.874675798 +0100
+++ tests/data/fate/filter-pp4  2015-03-11 11:27:01.911504671 +0100
@@ -1 +1 @@
-pp4                 0a2895c619ab9c6c22fd7cffb25070a8
+pp4
\ No newline at end of file
Test filter-pp failed. Look at tests/data/fate/filter-pp.err for details.
make: *** [fate-filter-pp] Error 139
Test filter-pp4 failed. Look at tests/data/fate/filter-pp4.err for details.
make: *** [fate-filter-pp4] Error 139
--- ./tests/ref/fate/filter-pp3 2015-03-11 00:31:17.874675798 +0100
+++ tests/data/fate/filter-pp3  2015-03-11 11:27:01.911504671 +0100
@@ -1 +1 @@
-pp3                 ef0f10f1859af2f75717e8c9d64ee38a
+pp3
\ No newline at end of file
Test filter-pp3 failed. Look at tests/data/fate/filter-pp3.err for details.
make: *** [fate-filter-pp3] Error 139
--- ./tests/ref/fate/filter-pp1 2015-03-11 00:31:17.874675798 +0100
+++ tests/data/fate/filter-pp1  2015-03-11 11:27:01.911504671 +0100
@@ -1 +1 @@
-pp1                 cb9f884e27a5be11f72afc9b517efd10
+pp1
\ No newline at end of file
Test filter-pp1 failed. Look at tests/data/fate/filter-pp1.err for details.
make: *** [fate-filter-pp1] Error 139


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150311/58c5b3f3/attachment.asc>