[FFmpeg-devel] [PATCH]Add one CRLF to http headers if necessary

Nicolas George george at nsup.org
Tue Mar 10 14:09:10 CET 2015

Le decadi 20 ventôse, an CCXXIII, Carl Eugen Hoyos a écrit :
> Please add a reference to ticket #3268 
> to the commit message.

I was about to reply "locally added", but no, because it does not fix that

Re-thinking on the whole discussion, I withdraw this patch, it is wrong. This
part of the code is an API, not an UI, so it is better if it is strict. I
will try to propose another patch for pure validation.

Regarding the trac ticket itself, I wrote this, and I stick to it:

# I am not in favour of fixing the shortcomings of the user's shell in
# FFmpeg's libraries

# If we are talking about end-user interface, the changes should happen in
# cmdutils.c.

In other words, I vote for closing #3268 as WONTFIX and suggesting windows
users to use a better shell (maybe the so-called powershell introduced in
the recent windows versions can do it).

If people really want to fix microsoft's shortcomings in FFmpeg, then it
must happen in the UI, not the API, i.e. in cmdutils.c. Maybe something like
that: "ffmpeg ... -expand -headers 'Cookies: chocolate\r\n'" (-expand being
a new option meaning "perform escape-character expansion on the following
option argument"). But I do not intend to work on it, because anybody can
get a shell where $'\r\n' works.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150310/83053b54/attachment.asc>

More information about the ffmpeg-devel mailing list