[FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

[Claudio Freire]

On Mon, Mar 9, 2015 at 1:38 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Mon, Mar 09, 2015 at 01:31:26PM -0300, Claudio Freire wrote:
>> On Mon, Mar 9, 2015 at 1:26 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > doesnt help
>> > but
>> > this does:
>> > -fate-aac-s7350-encode: CMD = enc_dec_pcm adts wav s16le $(REF) -strict -2 -c:a aac -b:a 256k
>> > +fate-aac-s7350-encode: CMD = enc_dec_pcm adts wav s16le $(REF) -strict -2 -c:a aac -b:a 88k
>> >
>> > this seems to fix it, didnt ivestigate why ...
>>
>> 88k is the maximum allowed bitrate at 7350hz, but it shouldn't make
>> any difference given that lavc/aacenc.c:775 already clamps the bitrate
>> to that number.
>
> i think it clamps to 88200 while 88k sets 88000
> i can reproduce the difference with -b:a 88200

Oh... I see.

There's a specific implementation for mips, I had completely
overlooked it on all patchesets.

I'll have to look into it more thoroughly, most earlier patches should
be applied to that implementation as well when applicable.