[FFmpeg-devel] [PATCH] Make compilable with VS2015

[James Almer]

On 06/03/15 6:06 PM, Hendrik Leppkes wrote:
> On Fri, Mar 6, 2015 at 10:00 PM, wm4 <nfxjfg at googlemail.com> wrote:
>> On Fri, 6 Mar 2015 14:59:43 -0500
>> "Ronald S. Bultje" <rsbultje at gmail.com> wrote:
>>
>>> Hi,
>>>
>>> On Fri, Mar 6, 2015 at 2:42 PM, Peter <dravorek at googlemail.com> wrote:
>>>
>>>> From c72344d2b1dc8b087e5da904724c959005f36f4b Mon Sep 17 00:00:00 2001
>>>> From: Peter Tissen <dravorek at gmail.com>
>>>> Date: Fri, 6 Mar 2015 19:39:27 +0100
>>>> Subject: [PATCH] Make compilable with VS2015
>>>>
>>>> So Visual Studio 2015 has some breaking changes regarding the C
>>>> runtime. In short, they made C99 compatable runtime.
>>>> Refer to
>>>> http://blogs.msdn.com/b/vcblog/archive/2014/06/18/crt-features-fixes-and-breaking-changes-in-visual-studio-14-ctp1.aspx
>>>>
>>>> Signed-off-by: Peter Tissen <dravorek at gmail.com>
>>>> ---
>>>>  configure            | 14 +++++++++-----
>>>>  libavutil/internal.h |  2 +-
>>>>  2 files changed, 10 insertions(+), 6 deletions(-)
>>>>
>>>> diff --git a/configure b/configure
>>>> index ce745d2..1ea2032 100755
>>>> --- a/configure
>>>> +++ b/configure
>>>> @@ -3531,7 +3531,9 @@ probe_cc(){
>>>>          _flags='-nologo'
>>>>          _cflags='-D_USE_MATH_DEFINES -D_CRT_SECURE_NO_WARNINGS
>>>> -Dinline=__inline -FIstdlib.h -Dstrtoll=_strtoi64'
>>>>          if [ $pfx = hostcc ]; then
>>>> -            append _cflags -Dsnprintf=_snprintf
>>>> +            if [ -z "$cl_major_ver" ] || [ $cl_major_ver -le 18 ]; then
>>>> +                append _cflags -Dsnprintf=_snprintf
>>>> +            fi
>>>
>>>
>>> Oh wow that's amazing! They fixed it! Hurray! I'm seriously happy.
>>
>> They still require calling _snprintf, though?
>>
> 
> No, one of the hunks remove this define if the compiler is > 18
> VS2015 should implement a fully C standard compliant snprintf. They
> also entirely revamped the implementation of all printf-related
> functions.
> 
> - Hendrik

Now that you mention, that hunk (if you mean the lavu/internal.h one) was not part of the 
github pull request and thus not applied.

Maybe it should...