[FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

[Claudio Freire]

On Fri, Mar 6, 2015 at 9:59 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Fri, Mar 06, 2015 at 04:28:38AM -0300, Claudio Freire wrote:
>> AAC: Add support for 7350Hz sampling rates, no error on too hight bitrate.
>>
>> Instead, warn that bitrate will be clamped down to the maximum allowed.
>>
>> Patch is mostly work of Kamendo2 in issue #2686, quite tested within that issue.
>>
>> Tested with abtest.sh and confirmed it does work as intended.
>
>>  aacenc.c |   23 ++++++++++++++++++-----
>>  1 file changed, 18 insertions(+), 5 deletions(-)
>> 030cd61fb3e5180d38e3d7b70c9cdce46cf17b3b  aac-bugfixes-3.patch
>> From df43314a67ad625775795561d960c30408fcf892 Mon Sep 17 00:00:00 2001
>> From: Claudio Freire <klaussfreire at gmail.com>
>> Date: Fri, 6 Mar 2015 04:05:32 -0300
>> Subject: [PATCH] AAC: Add support for 7350Hz sampling rates, no error on too
>>  hight bitrate.
>>
>> Instead, warn that bitrate will be clamped down to the maximum allowed.
>>
>> Patch is mostly work of Kamendo2 in issue #2686, quite tested within that issue.
>
> applied
>
> does it make sense to add a fate test for 7350Hz ?
>
> thanks


It does, but I'm not sure how that works.

I see that there's tests/fate/aac.mak with lots of tests, but

1- I'm not sure where the samples are, an extra sample at 7350hz would be needed
2- How to run that, make check dies at dct1d-4