[FFmpeg-devel] [PATCH 2/2] lavf/concatdef: pass options to nested input

[Zhang Rui]

2015-03-05 20:34 GMT+08:00 Nicolas George <george at nsup.org>:
> Le quintidi 15 ventôse, an CCXXIII, Zhang Rui a écrit :
>
>> Your solution is enough for my case.
>> And as you said, my patch may be not desirable.
>
> I believe it depends on the use case, and it is not completely obvious which
> side your example falls on.

In my situation, all segments are deployed on same http server,
and need same options. So both sides are OK for me.

In my own project, I would use read_header2 to specify options
for all segments which is convenient, and use per-file option for
special situations.

I'm also trying to introduce read_header2 into libavformat/hls.c,
which has been setting internal input options manually, incompletely
and dependently.
Obviously, we have no chance, and may have no need to set per-file
ffmpeg option in hls.

But I'm not sure read_headers2 is OK as an ffmpeg API,
Besides your concern about same options for all segments,
There is also a concern about same options for upper and lower inputs.

Would you mind to share more ideas about read_headers2 callback?

> But in the meantime I have started implementing per-file options for the
> concat demuxer, see the attached patch.

Looks great to me.
Do you have more WIP / plans / ideas on concatdec to share?