[FFmpeg-devel] [PATCH] lavfi: Add support to process_command in vf_eq.c

[Stefano Sabatini]

On date Friday 2015-02-20 01:11:40 +0100, Stefano Sabatini encoded:
> On date Thursday 2015-02-19 17:13:15 +0530, Arwa Arif encoded:
> > Updated the patch.
> 
> > From 66a8c9d03995c9e7c6ccc05fb9b20756f51c17f4 Mon Sep 17 00:00:00 2001
> > From: Arwa Arif <arwaarif1994 at gmail.com>
> > Date: Thu, 19 Feb 2015 01:26:44 +0530
> > Subject: [PATCH] Add process_command to eq.
> > 
> > ---
> >  doc/filters.texi    |   35 +++++++++++
> >  libavfilter/vf_eq.c |  171 +++++++++++++++++++++++++++++++++++++--------------
> >  libavfilter/vf_eq.h |   56 +++++++++++++++--
> >  3 files changed, 210 insertions(+), 52 deletions(-)
> > 
> > diff --git a/doc/filters.texi b/doc/filters.texi
> > index 191b52f..e5bf3a2 100644
> > --- a/doc/filters.texi
> > +++ b/doc/filters.texi
> > @@ -4402,6 +4402,41 @@ Default is @code{1.0}.
> >  
> >  @end table
> >  
> > + at subsection Commands
> > +The filter supports the following commands:
> > +
> > + at table @option
> > + at item contrast
> > +Set the contrast expression.
> > +
> > + at item brightness
> > +Set the brightness expression.
> > +
> > + at item saturation
> > +Set the saturation expression.
> > +
> > + at item gamma
> > +Set the gamma expression.
> > +
> > + at item gamma_r
> > +Set the gamma_r expression.
> > +
> > + at item gamma_g
> > +Set gamma_g expression.
> > +
> > + at item gamma_b
> > +Set gamma_b expression.
> > +
> > + at item gamma_weight
> > +Set gamma_weight expression.
> > +
> > +The command accepts the same syntax of the corresponding option.
> 
> What parameters do the expressions accept? Can you suggest some useful
> use-case? (And add useful examples in the docs?)
> 
> > +
> > +If the specified expression is not valid, it is kept at its current
> > +value.
> 
> Also, you should update the options section to make it clear that the
> filter options accept expressions as well.

@arwa, can you comment about these questions?

[...]
-- 
FFmpeg = Formidable & Fundamentalist Merciful Perfectionist Exuberant Generator