[FFmpeg-devel] [PATCH] libavformat/mxfdec: refactor reading strong ref array

Michael Niedermayer michaelni at gmx.at
Wed Mar 4 12:19:41 CET 2015

On Sun, Mar 01, 2015 at 06:33:10PM -0800, Mark Reid wrote:
> hi,
> I was unsure whether this should be a function or a macro, I went with a function.

i think functions are better, especially when you try to read a
backtrace in gdb
then again i think macros are better when you wonder why gcc didnt
inline that speed critical and trivial fuction and made the whole
software run half speed

I think the first case applies more often though

> ---
>  libavformat/mxfdec.c | 61 +++++++++++++++++++---------------------------------
>  1 file changed, 22 insertions(+), 39 deletions(-)



Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150304/15fa527a/attachment.asc>

More information about the ffmpeg-devel mailing list