[FFmpeg-devel] [RFC]Don't use round when encoding png

wm4 nfxjfg at googlemail.com
Sun Mar 1 13:11:08 CET 2015


On Sun, 1 Mar 2015 12:09:28 +0100
Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> On Sunday 01 March 2015 11:22:10 am Michael Niedermayer wrote:
> > On Sun, Mar 01, 2015 at 09:44:30AM +0100, Carl Eugen Hoyos wrote:
> > > Attached untested patch should fix compilation on broken platforms.
> > > We don't use round() currently because it appears less portable than
> > > lrintf().
> 
> > yes reducing float code usage should be fine, less potential to
> > cause problems with regression tests
> 
> New patch attached.
> 
> Please review, Carl Eugen

Seriously? You replace kind of magic, but sourced constants with
completely magic ones?


More information about the ffmpeg-devel mailing list