[FFmpeg-devel] [PATCH] vp9/update_prob: prevent out of bounds table read

Michael Niedermayer michaelni at gmx.at
Tue Jun 30 13:44:01 CEST 2015


On Tue, Jun 30, 2015 at 05:59:53AM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Tue, Jun 30, 2015 at 2:03 AM, James Zern <jzern at google.com> wrote:
> 
> > the max value of the lookup in expanded form is:
> > (((1 << 7) - 1) << 1) - 65 + 1 + 64 = 254
> >
> > add one entry of padding to inv_map_table[] to prevent out of bounds
> > access with non-conforming / fuzzed bitstreams
> >
> > Signed-off-by: James Zern <jzern at google.com>
> > ---
> >  libavcodec/vp9.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> 
> OK.

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150630/0dfaf6b2/attachment.asc>


More information about the ffmpeg-devel mailing list