[FFmpeg-devel] [PATCH] avcodec/codec_desc: rename smv video codec name to smvjpeg to match decoder name

[Reimar Döffinger]

On Tue, Jun 16, 2015 at 09:18:13PM +0200, Hendrik Leppkes wrote:
> On Tue, Jun 16, 2015 at 8:33 PM, wm4 <nfxjfg at googlemail.com> wrote:
> > On Tue, 16 Jun 2015 13:29:55 +0000
> > Paul B Mahol <onemda at gmail.com> wrote:
> >
> >> Also fixes clash with smv audio codec.
> >>
> >> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> >> ---
> >>  libavcodec/codec_desc.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c
> >> index c1694f3..f32843a 100644
> >> --- a/libavcodec/codec_desc.c
> >> +++ b/libavcodec/codec_desc.c
> >> @@ -1178,7 +1178,7 @@ static const AVCodecDescriptor codec_descriptors[] = {
> >>      {
> >>          .id        = AV_CODEC_ID_SMVJPEG,
> >>          .type      = AVMEDIA_TYPE_VIDEO,
> >> -        .name      = "smv",
> >> +        .name      = "smvjpeg",
> >>          .long_name = NULL_IF_CONFIG_SMALL("Sigmatel Motion Video"),
> >>      },
> >>
> >
> > An incompatible API change should come with a major bump.
> >
> 
> Strings in the codec descriptor are API now?

I have to admit there is precedence that it is not, as we changed names
before.
On the other hand I would like to point out that we have functions
to select by this name, and as such - and the fact that these renames
usually break _something_ - I would strongly prefer to consider this
API changes.
If nothing else because we shouldn't cause people trouble for a change
that is of no particular significance.