[FFmpeg-devel] [PATCH 03/11] aaccoder: add intensity stereo coding support for the trellis quantizer

[Michael Niedermayer]

On Sat, Jun 27, 2015 at 10:36:11PM -0300, Claudio Freire wrote:
> On Fri, Jun 26, 2015 at 5:16 PM, Rostislav Pehlivanov
> <atomnuker at gmail.com> wrote:
> > +/* Energy spread threshold value below which no PNS is used, this corresponds to
> > + * typically around 17Khz, after which PNS usage decays ending at 19Khz */
> > +#define NOISE_SPREAD_THRESHOLD 152234544.0f
> > +
> > +/* Above ~1.26*threshold all normally-zeroed values are PNS'd. Lambda divides
> > + * the defined value below as to try to get a ~1.26 multiplier so that there is
> > + * a balance between noise and zero bands leaving more bits for actual signal */
> > +#define NOISE_LAMBDA_NUMERATOR 252.1f
> 
> This should go to #09 shouldn't it?
> 
> > +
> > +/** Frequency in Hz for lower limit of intensity stereo   **/
> > +#define INT_STEREO_LOW_LIMIT 6000
> 
> And that to #10.
> 
> Or wherever it's used first, I'd say.
> 
> Other than that, it looks good.

removed the lines mentioned above and applied (as its required for the
next patch)

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150628/2c08cb37/attachment.asc>