[FFmpeg-devel] New asf demuxer

[wm4]

On Sun, 28 Jun 2015 16:46:12 +0200
Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> On Sunday 28 June 2015 04:42:30 pm Nicolas George wrote:
> > Le decadi 10 messidor, an CCXXIII, Carl Eugen Hoyos a écrit :
> > > But please allow me to repeat my question: Why do
> > > think the new demuxer should be used? What sample
> > > does it fix?
> >
> > Why do you think it should NOT be used?
> 
> The main reason imo is that it is (apparently, I may 
> of course be wrong) not intended to fix anything but 
> just to remove a demuxer that has seen many (man-) 
> years of testing.

The new demuxer was written based on the official ASF spec, and was
tested against a number of real world samples.

Also, the code being old is really meaningless here. The old demuxer
didn't handle all files well either and it's probably full of bugs.

> From a very quick look, the new code seems mostly 
> unreviewed 

This is wrong. The code has been in review for several months before it
was finally merged.

> which makes me think that it can't really 
> be tested.

This makes literally no sense at all. None.

> Do you disagree? Do you know of samples that work 
> better with the new demuxer?

It is known that it fixed some samples. Also, no samples are known yet
that break with the new demuxers. I only see some wild claims from you,
without providing actual sample files. Last but not least, if there are
samples which break the new demuxer, the author of the new demuxer
could probably easily fix them.

> (Except for the insult.)

I don't see where you got an insult.