[FFmpeg-devel] [PATCH] postproc: fix unaligned access

[Andreas Cadhalpun]

On 18.06.2015 22:26, Michael Niedermayer wrote:
> On Thu, Jun 18, 2015 at 08:29:06PM +0200, Andreas Cadhalpun wrote:
>> QP_store is only 8-bit-aligned, so accessing it as uint32_t causes
>> SIGILL crashes on sparc.
>>
>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
>> ---
>>  libpostproc/postprocess.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/libpostproc/postprocess.c b/libpostproc/postprocess.c
>> index 92cc436..e4ea515 100644
>> --- a/libpostproc/postprocess.c
>> +++ b/libpostproc/postprocess.c
>> @@ -996,10 +996,7 @@ void  pp_postprocess(const uint8_t * src[3], const int srcStride[3],
>>          if (QPStride >= 0){
>>              int i;
>>              const int count= FFMAX(mbHeight * QPStride, mbWidth);
>> -            for(i=0; i<(count>>2); i++){
>> -                ((uint32_t*)c->nonBQPTable)[i] = ((const uint32_t*)QP_store)[i] & 0x3F3F3F3F;
>> -            }
>> -            for(i<<=2; i<count; i++){
> 
> maybe this can be left under #if HAVE_FAST_UNALIGNED with
> AV_RN32 AV_WN32

Yes, updated patch attached.

Best regards,
Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-postproc-fix-unaligned-access.patch
Type: text/x-diff
Size: 1517 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150619/868c79fd/attachment.bin>