[FFmpeg-devel] [PATCH] avformat/qcp: s/unsigned int/uint32_t

[Ronald S. Bultje]

Hi,

On Mon, Jun 15, 2015 at 12:38 PM, Paul B Mahol <onemda at gmail.com> wrote:

> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
>  libavformat/qcp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/qcp.c b/libavformat/qcp.c
> index 9e2eedf..e2fd5ff 100644
> --- a/libavformat/qcp.c
> +++ b/libavformat/qcp.c
> @@ -139,7 +139,7 @@ static int qcp_read_packet(AVFormatContext *s,
> AVPacket *pkt)
>  {
>      AVIOContext *pb = s->pb;
>      QCPContext    *c  = s->priv_data;
> -    unsigned int  chunk_size, tag;
> +    uint32_t chunk_size, tag;
>
>      while(!avio_feof(pb)) {
>          if (c->data_size) {


Why? Typically people prefer elements sized for platform size, since in
some cases that may perform better (and unsigned int is guaranteed to be
>=32bit).

Ronald